[Date Prev] [Date Index] [Date Next] [Thread Prev] [Thread Index] [Thread Next]

[PATCH] Fix for invalid free on task execution.

Artem Savkov asavkov@redhat.com
Wed, 24 Sep 2014 14:52:38 GMT 

Hello All,

Attached patch fixes a SEGV mentioned by Anthony Gialluca in his
'SEGV in conserver ver 8.1.20' email.
The segfault is caused by an unitialized execSlave variable in
StartTask() which then calls FallBack().
The issue is still present in 8.2.0 and supplied patch is for this
version.

-- 
Regards,
  Artem

--- a/conserver/group.c	2014-09-18 17:08:03.390198988 +0200
+++ b/conserver/group.c	2014-09-18 17:08:25.886201733 +0200
@@ -1746,7 +1746,7 @@
     extern char **environ;
     char *pcShell, **ppcArgv;
     extern int FallBack(char **, int *);
-    char *execSlave;		/* pseudo-device slave side             */
+    char *execSlave = NULL;	/* pseudo-device slave side             */
     int execSlaveFD;		/* fd of slave side                     */
     int cofile;