Re: 8.1.17 spec file issue

Hi Fabien,


Wed, 14 Oct 2009 16:39:42 +0200 Fabien Wernli <wernli@in2p3.fr> wrote:

> could you be a little more verbose in the %changelog?

Hups, sure, sorry I missed that.
I just copied and pasted an different changelog 
entry from somewhere else and was about to change that but then I forgot it.

I attached a new version.


I did not change much from your original version:

# diff -B conserver.spec.orig conserver.spec
15c15
< %define distver 1
---
> %define distver 2 
27d26
< Summary: Serial console server daemon/client
31a31
> Summary: Serial console server daemon/client
50a51,57
> %package server
> Summary: Serial console server daemon
> Group: System Environment/Daemons
> 
> %package client
> Summary: Serial console server client
> Group: Applications/Internet 
53c60,66
< Conserver is an application that allows multiple users to watch a
---
> Conserver is a daemon that allows multiple users to watch a
> serial console at the same time.  It can log the data, allows users to
> take write-access of a console (one at a time), and has a variety of
> bells and whistles to accentuate that basic functionality.
> 
> %description server
> conserver-server is a daemon that allows multiple users to watch a
57a71,73
> %description client
> conserver-client to connect to conserver-server using a tcp port.
> Allows multiple users to watch a serial console at the same time.
100c116
< %post
---
> %post server
110c126
< %preun
---
> %preun server
117a134,135
> # we need this even if empty
> #%files
119c137
< %files
---
> %files server
126d143
< %{_bindir}/console
128d144
< %{_mandir}/man1/console.1.gz
135a152,157
> %files client 
> %defattr(-,root,root)
> %doc CHANGES FAQ INSTALL README
> %{_bindir}/console
> %{_mandir}/man1/console.1.gz
> 
136a159,161
> * Wed Oct 14 2009 Jodok Ole Muellers <muellejo@aschendorff.de> - 8.1.17-2 
>   - Changed the conserver.spec file to create separate subpackages 
>     for client and server by using the %package directive. 

-- 
Jodok Ole Müllers
Infrastruktur Manager
Red Hat Certified Engineer

#
# rpm spec file for conserver, but I don't think it'll work on any
# platform that doesn't have red hat rpm >= 4.0.2 installed.
#

%define pkg  conserver
%define ver  8.1.17

# define the name of the machine on which the main conserver
# daemon will be running if you don't want to use the default
# hostname (console)
%define master console

# what red hat (or other distibution) version are you running?
%define distver 3 

# compile arguments. defaults to 0
# example: rpmbuild -bb conserver.spec --with openssl
%define with_openssl %{?_with_openssl: 1} %{?!_with_openssl: 0}
%define with_libwrap %{?_with_libwrap: 1} %{?!_with_libwrap: 0}
%define with_pam     %{?_with_pam:     1} %{?!_with_pam:     0}
%define with_dmalloc %{?_with_dmalloc: 1} %{?!_with_dmalloc: 0}

# additionally you can use macros logfile pidfile
# example: rpmbuild -bb conserver.spec --define "pidfile /var/run/conserver/pid"

Name: %{pkg}
Version: %{ver}
Release: %{distver}
License: BSD
Summary: Serial console server daemon/client
Group: System Environment/Daemons
URL: http://www.conserver.com/
Source: http://www.conserver.com/%{pkg}-%{ver}.tar.gz
BuildRoot: %{_tmppath}/%{pkg}-buildroot
%if %{with_openssl}
BuildRequires: openssl-devel
%endif
%if %{with_pam}
BuildRequires: pam-devel
%endif
%if %{with_libwrap}
Requires: tcp_wrappers
%endif
%if %{with_dmalloc}
Requires: dmalloc
BuildRequires: dmalloc
%endif
Prefix: %{_prefix}

%package server
Summary: Serial console server daemon
Group: System Environment/Daemons

%package client
Summary: Serial console server client
Group: Applications/Internet 

%description
Conserver is a daemon that allows multiple users to watch a
serial console at the same time.  It can log the data, allows users to
take write-access of a console (one at a time), and has a variety of
bells and whistles to accentuate that basic functionality.

%description server
conserver-server is a daemon that allows multiple users to watch a
serial console at the same time.  It can log the data, allows users to
take write-access of a console (one at a time), and has a variety of
bells and whistles to accentuate that basic functionality.

%description client
conserver-client to connect to conserver-server using a tcp port.
Allows multiple users to watch a serial console at the same time.

%prep
%{__rm} -rf %{buildroot}
%setup -q


%build
# we don't want to install the solaris conserver.rc file
f="conserver/Makefile.in"
%{__mv} $f $f.orig
%{__sed} -e 's/^.*conserver\.rc.*$//' < $f.orig > $f

%configure %{?_with_openssl} %{?_with_libwrap} %{?_with_dmalloc} %{?_with_pam} %{?logfile: --with-logfile=%{logfile}} %{?pidfile: --with-pidfile=%{pidfile}} %{?master: --with-master=%{master}}

make


%install
%{makeinstall}

# put commented copies of the sample configure files in the
# system configuration directory
%{__mkdir_p} %{buildroot}/%{_sysconfdir}
%{__sed} -e 's/^/#/' \
  < conserver.cf/conserver.cf \
  > %{buildroot}/%{_sysconfdir}/conserver.cf
%{__sed} -e 's/^/#/' \
  < conserver.cf/conserver.passwd \
  > %{buildroot}/%{_sysconfdir}/conserver.passwd

# install copy of init script
%{__mkdir_p} %{buildroot}/%{_initrddir}
%{__cp} contrib/redhat-rpm/conserver.init %{buildroot}/%{_initrddir}/conserver

# install copy of init script defaults
%{__mkdir_p} %{buildroot}/%{_sysconfdir}/default
%{__cp} contrib/redhat-rpm/conserver.defaults %{buildroot}/%{_sysconfdir}/default/conserver

%clean
%{__rm} -rf %{buildroot}


%post server
if [ -x %{_initrddir}/conserver ]; then
  /sbin/chkconfig --add conserver
fi
# make sure /etc/services has a conserver entry
if ! egrep '\<conserver\>' /etc/services > /dev/null 2>&1 ; then
  echo "console		782/tcp		conserver" >> /etc/services
fi


%preun server
if [ "$1" = 0 ]; then
  if [ -x %{_initrddir}/conserver ]; then
    %{_initrddir}/conserver stop
    /sbin/chkconfig --del conserver
  fi
fi

# we need this even if empty
#%files

%files server
%defattr(-,root,root)
%doc CHANGES FAQ INSTALL README conserver.cf
%config(noreplace) %{_sysconfdir}/conserver.cf
%config(noreplace) %{_sysconfdir}/conserver.passwd
%config(noreplace) %{_sysconfdir}/default/conserver
%attr(555,root,root) %{_initrddir}/conserver
%{_libdir}/conserver/convert
%{_mandir}/man8/conserver.8.gz
%{_mandir}/man5/conserver.cf.5.gz
%{_mandir}/man5/conserver.passwd.5.gz
%{_datadir}/examples/conserver/conserver.cf
%{_datadir}/examples/conserver/conserver.passwd
%{_sbindir}/conserver

%files client 
%defattr(-,root,root)
%doc CHANGES FAQ INSTALL README
%{_bindir}/console
%{_mandir}/man1/console.1.gz

%changelog
* Wed Oct 14 2009 Jodok Ole Muellers <muellejo@aschendorff.de> - 8.1.17-3 
  - Changed the conserver.spec file to create separate subpackages 
    for client and server by using the %package directive. 
* Wed Sep 25 2009 Fabien Wernli
  - added configure prerequisites
* Thu Sep 24 2009 Fabien Wernli
  - added prefix to configure
  - changed some hardcoded values to proper macros:
    didn't work on x64 lib -> lib64